keisei/KeiSeiKit-1.0
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
KeiSeiKit-1.0/_capabilities/policy/git-ops-scope/text.md
Parfii-bot 5f7a5b2639 fix(wave18): 8 HIGH audit findings closed + three-role pipeline actually built 
47 crates, 801 tests green (up from 771 at v0.34.0). Wave 18 audit
found 8 HIGH findings across architect/critic/security/validator. All
closed. Three-role pipeline REBUILT after validator discovered Wave 16
commit was a half-commit (files claimed but never tracked).

## A. Three-role pipeline (REBUILD — was missing from v0.33.0 despite
      CHANGELOG claim)

Files validator flagged absent: _roles/auditor.toml + merger.toml,
4 _capabilities/{policy/git-ops-scope,output/verdict,output/merge-result,
verify/fork-audit}/text.md, kei-spawn/src/{pipeline,precedent}.rs,
pipeline_smoke.rs + pipeline_unit.rs tests. ALL NOW REAL (verified by
git log --all and `ls`).

- auditor role: claude-subagent-type=critic, handoff=[merger]
- merger role: git-ops scope, claude-subagent-type=infra-implementer,
  leaf (empty handoff)
- 5 capability text.md (+ capability.toml for each) defining contracts
- kei-spawn pipeline.rs (171 LOC): pipeline_from_role, derive_steps,
  emit_pipeline_json, scaffold_downstream_tasks
- kei-spawn precedent.rs (118 LOC): env-gated advisory shell-out
- --pipeline flag on spawn subcommand
- +11 tests (pipeline_smoke + pipeline_unit)

## B. kei-fork — 4 HIGH fixes (Critic F1+F7a, Security #3+#4)

- `git add -A` → explicit path list from ls-untracked + ls-modified,
  with exclusion filter for .DONE / .KEI_FORK_META.toml / _archive/ /
  _forks/. No more merge bleed. +1 regression test.
- create() rollback: on write_meta or ledger_fork failure, worktree
  + branch cleaned. +1 test via KEI_FORK_FORCE_LEDGER_FAIL=1.
- worktree_add arg injection: added `--` sentinel + is_safe_refname()
  validator (refuses dash-leading, NUL, ..). +3 tests.
- PATH hijack: KEI_FORK_GIT_BIN env override for all Command::new(git).
  +1 test.

## C. kei-spawn — 2 HIGH fixes (Security #1+#2)

- HTTP body unbounded DoS: MAX_BODY_BYTES=10MiB + content-length
  pre-check + streamed cap (io::Read::take) for chunked encoding.
  +2 feature-gated tests.
- PATH hijack: KEI_LEDGER_BIN env override already existed at
  ledger_sh.rs:15; documented precedence + added 4 regression tests
  locking the 3-tier lookup order.

## D. kei-ledger-sign — 1 HIGH fix (Security #2)

- save_keypair atomic POSIX open(2) O_CREAT|O_EXCL + mode 0o600 +
  rename(2) into place. No race window where key is world-readable.
  +2 tests.

## E. spawn_from_task rollback (Critic F7b)

- register_in_ledger helper: on ledger fork failure, rollback_task_dir
  before error propagation. +1 test spawn_rolls_back_task_dir_on_ledger_fail.

## Audit summary

- architect: GO conditional (taxonomy 19% — defer)
- critic: HIGH closed, MEDIUM debt logged
- security: 4 HIGH closed; MEDIUM (tar symlink, watcher symlink) tracked
- validator: CHANGELOG no longer lies — three-role pipeline is real
- patent-compliance: GO / LOW risk unchanged

All 8 HIGH blockers from Wave 18 consolidated audit → GREEN.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-23 20:54:59 +08:00

1.8 KiB
Raw Blame History

Git-ops scope (merger-only)

You ARE permitted to invoke the following shell commands. Every other command is denied by the policy::git-ops-scope gate:

  • git — any subcommand (merge, fetch, push, tag, log, show, diff, branch, reset, revert, rebase, cherry-pick). Used to integrate the writer's fork into main.
  • kei-fork — any subcommand (collect, gc, rescue, list, body-sha). The managed-worktree primitive. Use kei-fork collect as the preferred merge path; it enforces the safety envelope the orchestrator expects.
  • kei-ledger — any subcommand (done, fail, list, show). Close the ledger row for the fork you merged. MUST be consistent with actual commit state.

Explicitly denied (will be blocked by the gate):

  • rm, mv, cp — no raw filesystem mutations.
  • curl, wget, nc — no network fetches. If you need to push to a remote, use git push (which is in scope).
  • cargo run, ./script.sh, python — no arbitrary program execution. Use git / kei-fork / kei-ledger only.
  • sudo, ssh — no privilege escalation, no remote hosts.
  • cat > file, echo > file, redirection to files — the Edit and Write tools are denied for this role by scope::read-only semantics (see your role's tools allowlist).

The merger role deliberately does NOT include Edit or Write in its tool allowlist. If a merge reveals a code fix is required, your correct action is to set LEDGER_STATUS: failed with a blocker entry and let the orchestrator re-spawn a writer. Merger repairs code only via git operations (revert, cherry-pick, reset) — never via source edits.

Gate severity: enforce. A denied command will error and you must revise, not retry. Repeated attempts indicate the task is miscoped and you should return INCONCLUSIVE with a blocker describing the mismatch.