7b112747e4
Three independent manifest fixes from Opus TOML + Sonnet TOML + Sonnet Markdown audits. 1. TOML scope-capture (Sonnet TOML, HIGH) _manifests/critic-anti-pattern.toml + critic-perf.toml had [references] appearing AFTER [[handoff]] array-of-tables. Per TOML spec, this makes [references] parse as a SUB-TABLE of the last [[handoff]] element, not as a top-level table. All references in those manifests were silently unreachable by the assembler's top-level resolver. Moved [references] block before [[handoff]] in both files. Added 3-line warning comment immediately above [[handoff]] explaining the TOML scope rule to future editors. 2. Dangling physics-deriver in role bodies (Opus TOML, HIGH) Group F earlier (commitbaf5425) removed [[handoff]] blocks targeting physics-deriver / patent-compliance / patent-researcher, but role text strings + forbidden_domain arrays still referenced physics-deriver in: - _manifests/ml-researcher.toml (lines 16, 41, 76, 89) - _manifests/ml-implementer.toml (line 15) - _manifests/infra-implementer.toml (line 16) — already scrubbed in P0 commit94f31eeas part of EC2-ID strip; leaving for context Replaced live mentions with "architect" (canonical fallback). Historical comments documenting the prior removal kept intentionally — they are documentation, not live references. 3. Wrong rule paths (Opus TOML, MEDIUM) ml-researcher.toml + ml-implementer.toml referenced files that don't exist under their stated paths: - path:user-rules/specialized-node-training.md → cfc-specialized-nodes.md - path:user-rules/observable-classification.md → paradigm-native-measurement.md Fixed both paths in both files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
47 lines
1.4 KiB
TOML
47 lines
1.4 KiB
TOML
# Atomar agent — auto-generated 2026-04-29 (RULE ZERO decomposition).
|
|
# 1 cube = 1 responsibility. Edit this manifest, not the .md.
|
|
|
|
name = "critic-anti-pattern"
|
|
description = "Detects code anti-patterns: god classes, deep inheritance, shotgun surgery, primitive obsession. Read-only."
|
|
tools = ["Glob", "Grep", "Read"]
|
|
model = "sonnet"
|
|
substrate_role = "read-only"
|
|
|
|
role = """
|
|
You sweep code for classical anti-patterns. You DO NOT cover security (security-auditor-*) or performance (critic-perf). Severity-sorted findings with file:line evidence. No fixes — only reports.
|
|
"""
|
|
|
|
blocks = [
|
|
"baseline",
|
|
"evidence-grading",
|
|
"memory-protocol",
|
|
]
|
|
|
|
domain_in = ["task scope (verbatim user prompt)", "target paths / files"]
|
|
forbidden_domain = ["hardcoded secrets (RULE 0.8)", "cross-language drift (use the matching sibling)"]
|
|
output_extra_fields = ["Largest file LOC", "Tests pass count"]
|
|
|
|
[references]
|
|
extra = [
|
|
"path:user-rules/code-style.md",
|
|
"path:user-rules/karpathy-behavioral.md",
|
|
]
|
|
|
|
# IMPORTANT (TOML spec): all [table] sections must precede [[array]] sections.
|
|
# Adding a new [section] BELOW [[handoff]] makes it a sub-table of the last handoff.
|
|
[[handoff]]
|
|
target = "validator"
|
|
trigger = "general fact-check fallback"
|
|
|
|
[taxonomy]
|
|
kingdom = "manifest"
|
|
mechanism = "compose"
|
|
domain = "agent"
|
|
layer = "agent-substrate"
|
|
stage = "design-time"
|
|
stability = "stable"
|
|
language = "toml"
|
|
|
|
[lineage]
|
|
creator = "ag-orchestrator-human"
|
|
created = "2026-04-29"
|