f77c1b7fdc
Security hotfix — v0.15.1 Wave 1 fixes from 4-parallel audit. RED-1 (CVE): KEI_DISABLED_HOOKS tokenized match — was `*all*` substring-glob (trivially bypassable via "install", "wall-clock", etc.), now exact-token split on comma/space. Patched in all 9 hooks: no-hand-edit-agents, assemble-agents, assemble-validate, tomd-preread, agent-fork-logger, site-wysiwyd-check, error-spike-detector, milestone-commit-hook, session-end-dump. RED-2 (observability): minimal profile whitelist now includes agent-fork-logger and session-end-dump (ledger + trace paths) so observability is not silently lost on minimal installs. HIGH: review.json schema minItems:1 on findings — rejects empty reviews; new Rust test review_schema_rejects_empty_findings. HIGH: typed-handoff wire-up — produces_artifact declared at top level on 5 manifests (kei-security-auditor, kei-validator, kei-architect, kei-code-implementer, kei-critic); duplicate per-handoff declarations removed. MED: kei-artifact validate.rs gains warn_unsupported_keywords — non-fatal stderr warning when schema uses keywords outside the hand-rolled 2020-12 subset. LOW: CI Node matrix dropped 18, now ['20','22']. Doc drift: skills/hooks-control/SKILL.md reflects tokenized-match semantics and updated minimal-profile hook list. Tests: 191 Rust workspace + 30 assembler (both pass). RED-1 reproducer 10/10 (4 former-CVE vectors blocked, 5 legit vectors accepted, empty passes). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
80 lines
2.8 KiB
Bash
Executable file
80 lines
2.8 KiB
Bash
Executable file
#!/bin/sh
|
|
# PreToolUse(Edit|Write) — block hand-editing generated agent .md files.
|
|
#
|
|
# Generated files start with: <!-- GENERATED by _assembler ...
|
|
# Edit the manifest at _manifests/<name>.toml instead.
|
|
#
|
|
# Override: set AGENT_MIGRATION=1 in env to allow hand edits (migration / emergency).
|
|
#
|
|
# Stdin: JSON with tool_input.file_path
|
|
|
|
# Silent fall-through if jq is absent; otherwise `set -eu` would abort and
|
|
# Claude Code would refuse Edit/Write system-wide.
|
|
command -v jq >/dev/null 2>&1 || exit 0
|
|
|
|
# --- RUNTIME CONTROLS (v0.15.1) ---
|
|
# KEI_DISABLED_HOOKS: tokenized exact-match list (comma- or space-separated).
|
|
# Repro of pre-v0.15.1 substring bypass (CVE-class): KEI_DISABLED_HOOKS="foo-all-bar"
|
|
# previously disabled every hook via `*all*`. v0.15.1 requires token equality.
|
|
_hook_name="$(basename "$0" .sh)"
|
|
_disabled=" $(printf '%s' "${KEI_DISABLED_HOOKS:-}" | tr ',' ' ') "
|
|
case "$_disabled" in
|
|
*" $_hook_name "*|*" all "*) unset _disabled; exit 0 ;;
|
|
esac
|
|
unset _disabled
|
|
case "${KEI_HOOK_PROFILE:-full}" in
|
|
off) exit 0 ;;
|
|
minimal)
|
|
case "$_hook_name" in
|
|
no-hand-edit-agents|assemble-validate|agent-fork-logger|session-end-dump) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
;;
|
|
advisory-off)
|
|
case "$_hook_name" in
|
|
recurrence-suggest|citation-verify|error-spike-detector|milestone-commit-hook) exit 0 ;;
|
|
esac
|
|
;;
|
|
full|*) ;;
|
|
esac
|
|
# --- end runtime controls ---
|
|
|
|
set -eu
|
|
|
|
[ "${AGENT_MIGRATION:-0}" = "1" ] && exit 0
|
|
|
|
FILE=$(jq -r '.tool_input.file_path // empty')
|
|
[ -n "$FILE" ] || exit 0
|
|
|
|
# Only care about files directly under ~/.claude/agents/*.md
|
|
# (not blocks/, manifests/, assembler/, template, generated preview)
|
|
#
|
|
# NOTE on staleness: we use the `<!-- GENERATED by _assembler -->` marker
|
|
# on line 1 as the SOLE SOURCE OF TRUTH for "is this file generated?".
|
|
# Legacy agent .md files that were produced before the assembler existed
|
|
# (and therefore lack the marker) will pass this hook silently. That is
|
|
# intentional — the marker is how the assembler self-declares ownership,
|
|
# and any file without it is assumed hand-authored. Re-run the assembler
|
|
# to adopt an older file into the managed set.
|
|
case "$FILE" in
|
|
"$HOME/.claude/agents/_"*) exit 0 ;;
|
|
"$HOME/.claude/agents/"*.md) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
|
|
# Detect generated marker in the first 10 lines (sole truth — see NOTE above)
|
|
if [ -f "$FILE" ] && head -10 "$FILE" | grep -q 'GENERATED by _assembler'; then
|
|
NAME=$(basename "$FILE" .md)
|
|
echo "[no-hand-edit-agents] BLOCKED: $FILE is generated." >&2
|
|
echo "" >&2
|
|
echo "Edit the manifest instead:" >&2
|
|
echo " ~/.claude/agents/_manifests/$NAME.toml" >&2
|
|
echo "" >&2
|
|
echo "Or edit a shared block:" >&2
|
|
echo " ~/.claude/agents/_blocks/<block>.md" >&2
|
|
echo "" >&2
|
|
echo "Override (emergency only): export AGENT_MIGRATION=1" >&2
|
|
exit 1
|
|
fi
|
|
|
|
exit 0
|