12-agent audit (2 waves Opus+Sonnet, 6 slices each) flagged 3 HIGH-tier
issues that BOTH waves agreed on, plus 5 doc-honesty findings. This
batch fixes the lot.
== CI green (was failing on main 94a7d68) ==
- _primitives/_rust/Cargo.toml — workspace tokio gains `io-std` feature
(needed by kei-mcp/src/main.rs which calls tokio::io::{stdin,stdout})
- _primitives/_rust/kei-mcp/Cargo.toml — dev-deps tokio gains `test-util`
feature (needed by tests/tools_call_timeout.rs for tokio::time::advance
and Builder::start_paused). Both verified locally:
`cargo check -p kei-mcp` ✓
`cargo test --no-run -p kei-mcp` ✓ (3 test binaries link)
[REAL: ran 2026-05-03 in this session]
== HIGH-tier audit fixes (consensus across waves) ==
1. SQLi escape in agent-outcome-backfill.sh:110
- 4 of 12 agents flagged: TOOL_USE_ID was JSON-derived and
interpolated raw into SQL. Allowlist on $SHIPPED protected today
but a future case-statement removal opened the surface.
- Fix: tiny `_sql_esc` helper that doubles single-quotes (SQL-99
standard escape), applied to SHIPPED + TOOL_USE_ID. STUBS already
integer-validated.
2. PRAGMA user_version=9 in install/sql/outcome-only-schema.sql
- W1 outcome-only critic flagged: the SQL fallback installed a
v9-equivalent flat schema but left user_version=0. A LATER
`kei-ledger init` (e.g. when user upgrades to full kit) would
re-run migrations v1-v9 and ALTER TABLE ADD COLUMN duplicate-error
mid-migration → broken DB.
- Fix: set PRAGMA user_version=9 before COMMIT so the binary's
migration runner sees current ≥ target and short-circuits.
3. backup_file mv→cp + uninstall macOS-portable awk
- W1+W2 outcome-only flagged: lib-backup.sh uses `mv` which DELETES
the target before _jq_merge_hooks runs; `|| true` swallowed the
subsequent jq read-error → silent settings.json loss.
- Fix in lib-profile-outcome-only.sh: `cp -p` aside, drop `|| true`,
return 1 on merge failure (trap restores).
- PROFILE-OUTCOME-ONLY.md uninstall used GNU sed `,+1` extension
which BSD sed (macOS) does not support — uninstall silently
no-op'd on macOS, leaving orphan CLAUDE.md text.
- Fix: replace with portable `awk` recipe; also added `rm -f` for
the agent-toolstats.jsonl sidecar (privacy completeness).
== Doc honesty pass (RULE 0.18 numerics + RULE 0.4 citations) ==
4. README.md count drift — verified all values against filesystem:
* 102→105 Rust crates (Cargo.toml workspace `members` count)
* 67→68 skills (`ls skills/ | wc -l`)
* 35→38 hooks (`grep -c '"command":' settings-snippet.json`)
* 37→38 agent manifests (`ls _manifests/*.toml | wc -l`)
* 82→85 substrate blocks (`find _blocks/ -name '*.md' | wc -l`)
* 18 capability atoms VERIFIED via `find _capabilities/ -name '*.md'`
(encyclopedia §3 row count of 17 is in a separate file and is a
known internal display issue, not changed in this commit)
* 495→565 active DNAs (per docs/DNA-INDEX.md header 2026-05-03)
Each value now carries a `[REAL: <command>]` style trailer per
RULE 0.18.
5. README.md DNA "80-char identity" → "≥33-char variable-length"
- W1+W2 reviewer-pass flagged FALSE: docs/DNA-FORMAT.md SSoT says
minimum 33 chars; 80 was nowhere in code or spec
- Fix in README.md:36 + docs/PHILOSOPHY.md:39 + docs/DNA-INDEX.md:1352
6. README.md "Eleven install profiles (... Cursor / Continue / Zed /
Aider / Docker / Nix)" — Cursor/Continue/Zed/Aider/Docker/Nix were
never install profiles, they were bridge targets
- Fix: list 12 actual profiles from _primitives/MANIFEST.toml,
mention bridges as separate concept
7. .claude-plugin/plugin.json license MIT → Apache-2.0
- W2-Sonnet reviewer flagged: LICENSE file is Apache-2.0 (since
2026-04-30 per NOTICE), but plugin.json still declared MIT —
plugin marketplace would show wrong license
8. docs/ARCHITECTURE.md:318 placeholder URL `https://example.invalid/...`
- W2-Sonnet reviewer flagged: dead link in published docs
- Fix: remove the bad href, describe ssl-rule-file as per-user
install outside the public repo
9. skills/sleep-on-it/SKILL.md Wagner et al. 2004 citation
- W1+W2 reviewer flagged RULE 0.4 violation: citation without
verification marker
- Fix: added [VERIFIED: doi:10.1038/nature02223] + clarification
that the original paper showed slow-wave-sleep (not strictly REM)
insight gain — our metaphor is a loose mapping
10. encyclopedia/substrate-overview.md §5 fabricated TS deps
- W1-Opus doc-consistency flagged RULE 0.4.b violation: 5 of 6
package rows had INVENTED dependency strings
(`recall-ai-sdk ^1.0.0`, `nodemailer-mock ^2.0.0`,
`telegram-typings ^4.10.0`, etc — none exist in the actual
package.json files)
- Fix: regenerated table from real `package.json` reads via
`node -p "require(...).dependencies"` for each of the 6 packages
- Fix: also corrected version drift (5 packages all 0.14.0 now)
Verification:
- Outcome-only end-to-end install against fake $HOME succeeds:
hooks installed, ledger schema at user_version=9, settings.json
created cleanly, all 5 documented files present
[REAL: ran 2026-05-03 in this session]
- `cargo check -p kei-mcp` + `cargo test --no-run -p kei-mcp` clean
Audit findings NOT yet addressed (deferred to next batch):
- README:65 git clone github URL — repo is private; reviewer flagged
external strangers cannot clone; will resolve via Quick Start rewrite
- npm.pkg.github.com / @keisei84 leftover sweep — both waves verified
ZERO refs, no fix needed
- safeEqual timing leak in TS server (W2 sec MEDIUM)
- HTTP server bind 0.0.0.0 (W2 sec MEDIUM)
- Unbounded request body (W2 ci MEDIUM)
- --dry-run silent ignored on non-outcome profiles (W1+W2 MEDIUM)
- Doc-link missing for MEMORY/DNA/LEDGER format specs from README
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
75 lines
3.1 KiB
SQL
75 lines
3.1 KiB
SQL
-- outcome-only-schema.sql — minimal SQLite schema for the outcome-only
|
|
-- profile. Mirrors `_primitives/_rust/kei-ledger/src/migrations_list.rs`
|
|
-- but flattened: a single transaction that creates the v9-equivalent
|
|
-- shape of `agents` + `skill_invocations`. No PRAGMA user_version bump
|
|
-- is performed (the Rust runner expects to own that); if/when the user
|
|
-- later upgrades to a full kit install, `kei-ledger init` is idempotent
|
|
-- — IF NOT EXISTS guards keep both paths compatible.
|
|
--
|
|
-- Two tables:
|
|
-- agents → outcome rows (kei-model-router posterior)
|
|
-- skill_invocations → per-skill load events (Phase D metrics)
|
|
|
|
BEGIN IMMEDIATE;
|
|
|
|
CREATE TABLE IF NOT EXISTS agents (
|
|
id TEXT PRIMARY KEY,
|
|
branch TEXT NOT NULL,
|
|
parent_branch TEXT,
|
|
spec_sha TEXT NOT NULL,
|
|
status TEXT NOT NULL CHECK (status IN ('running','done','failed','merged','rejected')),
|
|
started_ts INTEGER NOT NULL,
|
|
finished_ts INTEGER,
|
|
summary TEXT,
|
|
worktree_path TEXT,
|
|
dna TEXT,
|
|
creator_id TEXT,
|
|
fork_parent_id TEXT,
|
|
cost_cents INTEGER DEFAULT 0,
|
|
provider TEXT DEFAULT '',
|
|
model TEXT DEFAULT '',
|
|
cost_micro_cents INTEGER DEFAULT 0,
|
|
tokens_in INTEGER,
|
|
tokens_out INTEGER,
|
|
stubs_count INTEGER DEFAULT 0,
|
|
outcome TEXT CHECK (outcome IS NULL OR outcome IN ('functional','partial','scaffolding','fail')),
|
|
escalation_depth INTEGER DEFAULT 0,
|
|
task_class_dna TEXT GENERATED ALWAYS AS (
|
|
CASE
|
|
WHEN dna IS NULL OR dna = '' THEN NULL
|
|
WHEN length(dna) > 9
|
|
AND substr(dna, length(dna) - 8, 1) = '-'
|
|
THEN substr(dna, 1, length(dna) - 9)
|
|
ELSE dna
|
|
END
|
|
) VIRTUAL
|
|
);
|
|
CREATE INDEX IF NOT EXISTS idx_parent ON agents(parent_branch);
|
|
CREATE INDEX IF NOT EXISTS idx_status ON agents(status);
|
|
CREATE INDEX IF NOT EXISTS idx_agents_dna_prefix ON agents(substr(dna, 1, 30));
|
|
CREATE UNIQUE INDEX IF NOT EXISTS idx_agents_dna_unique ON agents(dna);
|
|
CREATE INDEX IF NOT EXISTS idx_agents_creator ON agents(creator_id);
|
|
CREATE INDEX IF NOT EXISTS idx_agents_fork_parent ON agents(fork_parent_id);
|
|
CREATE INDEX IF NOT EXISTS idx_agents_task_class ON agents(task_class_dna);
|
|
|
|
CREATE TABLE IF NOT EXISTS skill_invocations (
|
|
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
|
skill_name TEXT NOT NULL,
|
|
ts INTEGER NOT NULL,
|
|
agent_id TEXT,
|
|
success INTEGER NOT NULL CHECK(success IN (0, 1)),
|
|
trajectory_id TEXT,
|
|
duration_ms INTEGER
|
|
);
|
|
CREATE INDEX IF NOT EXISTS idx_skill_invocations_name_ts
|
|
ON skill_invocations(skill_name, ts DESC);
|
|
CREATE INDEX IF NOT EXISTS idx_skill_invocations_success
|
|
ON skill_invocations(skill_name, success);
|
|
|
|
-- Audit fix 2026-05-03: bump user_version to 9 so a later `kei-ledger init`
|
|
-- short-circuits via the `current >= 9` gate instead of replaying v1..v9
|
|
-- migrations whose ALTER TABLE ADD COLUMN steps would error with "duplicate
|
|
-- column" against the already-flat schema this file installed.
|
|
PRAGMA user_version = 9;
|
|
|
|
COMMIT;
|