KeiSeiKit-1.0

keisei/KeiSeiKit-1.0

Fork 0

Commit graph

Author	SHA1	Message	Date
Parfii-bot	5f7a5b2639	fix(wave18): 8 HIGH audit findings closed + three-role pipeline actually built 47 crates, 801 tests green (up from 771 at v0.34.0). Wave 18 audit found 8 HIGH findings across architect/critic/security/validator. All closed. Three-role pipeline REBUILT after validator discovered Wave 16 commit was a half-commit (files claimed but never tracked). ## A. Three-role pipeline (REBUILD — was missing from v0.33.0 despite CHANGELOG claim) Files validator flagged absent: _roles/auditor.toml + merger.toml, 4 _capabilities/{policy/git-ops-scope,output/verdict,output/merge-result, verify/fork-audit}/text.md, kei-spawn/src/{pipeline,precedent}.rs, pipeline_smoke.rs + pipeline_unit.rs tests. ALL NOW REAL (verified by git log --all and `ls`). - auditor role: claude-subagent-type=critic, handoff=[merger] - merger role: git-ops scope, claude-subagent-type=infra-implementer, leaf (empty handoff) - 5 capability text.md (+ capability.toml for each) defining contracts - kei-spawn pipeline.rs (171 LOC): pipeline_from_role, derive_steps, emit_pipeline_json, scaffold_downstream_tasks - kei-spawn precedent.rs (118 LOC): env-gated advisory shell-out - --pipeline flag on spawn subcommand - +11 tests (pipeline_smoke + pipeline_unit) ## B. kei-fork — 4 HIGH fixes (Critic F1+F7a, Security #3+#4) - `git add -A` → explicit path list from ls-untracked + ls-modified, with exclusion filter for .DONE / .KEI_FORK_META.toml / _archive/ / _forks/. No more merge bleed. +1 regression test. - create() rollback: on write_meta or ledger_fork failure, worktree + branch cleaned. +1 test via KEI_FORK_FORCE_LEDGER_FAIL=1. - worktree_add arg injection: added `--` sentinel + is_safe_refname() validator (refuses dash-leading, NUL, ..). +3 tests. - PATH hijack: KEI_FORK_GIT_BIN env override for all Command::new(git). +1 test. ## C. kei-spawn — 2 HIGH fixes (Security #1+#2) - HTTP body unbounded DoS: MAX_BODY_BYTES=10MiB + content-length pre-check + streamed cap (io::Read::take) for chunked encoding. +2 feature-gated tests. - PATH hijack: KEI_LEDGER_BIN env override already existed at ledger_sh.rs:15; documented precedence + added 4 regression tests locking the 3-tier lookup order. ## D. kei-ledger-sign — 1 HIGH fix (Security #2) - save_keypair atomic POSIX open(2) O_CREAT\|O_EXCL + mode 0o600 + rename(2) into place. No race window where key is world-readable. +2 tests. ## E. spawn_from_task rollback (Critic F7b) - register_in_ledger helper: on ledger fork failure, rollback_task_dir before error propagation. +1 test spawn_rolls_back_task_dir_on_ledger_fail. ## Audit summary - architect: GO conditional (taxonomy 19% — defer) - critic: HIGH closed, MEDIUM debt logged - security: 4 HIGH closed; MEDIUM (tar symlink, watcher symlink) tracked - validator: CHANGELOG no longer lies — three-role pipeline is real - patent-compliance: GO / LOW risk unchanged All 8 HIGH blockers from Wave 18 consolidated audit → GREEN. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-23 20:54:59 +08:00
Parfii-bot	32f2e8a288	feat(wave15): kei-dna-index + kei-fork Option-D path convention fix 46 crates, 744 tests green (up from 726 at v0.31.0). ## kei-dna-index (new) — read-only adjacency analysis over kei-ledger Answers "who else touched same files / solved same task / ran nearby in time". Does NOT mutate ledger — parses DNA strings in memory. Respects SSoT (DNA string is the single source; columns NOT duplicated). Public API: - adjacent(target_dna, kind) — 5 kinds: Scope / Body / Role / Temporal / All - cluster_by(scope\|body\|role) — group DNAs, ≥2 members per cluster - precedent(body_sha, status_filter) — find past successful runs of same task - stats — totals, unique scopes/bodies, avg cluster size CLI: - kei-dna-index adjacent --dna D [--by kind] [--limit N] [--db PATH] - kei-dna-index cluster --by scope\|body\|role - kei-dna-index precedent --body HEX [--status merged\|failed\|all] - kei-dna-index stats 18 tests pass (13 integration + 5 parsed unit). Zero sibling deps (no kei-ledger, no kei-agent-runtime path imports — standalone tool). Separation of concerns: kei-ledger stays PURE provenance primitive. Analytical layer lives in kei-dna-index. Can swap implementations (naive scan → cached → embeddings) without touching ledger schema. ## kei-fork v0.31.2 — Option D path convention Moved fork worktree root from `.claude/forks/<id>/` to `_forks/<id>/`. Reasons: - `.claude/` is Anthropic-reserved; kit artefacts shouldn't pollute it - Claude Code sandbox denies Write in `.claude/forks/` for agents - `_forks/` matches existing kit convention (_primitives/, _roles/, _archive/, _blocks/, _capabilities/, _agents/) - Independent namespace — no coupling to Claude Code internals 13 existing kei-fork tests still pass (they use tempfile kit_roots so path convention is transparent). ## Usage enabled by these two - kei-prune can now query "all DNAs in same scope-cluster" → retire dupes - kei-brain-view can cluster-render instead of tree-render - Three-role pipeline (writer/auditor/merger) can use precedent() to find successful past patterns for same body-hash - Agents with worktree isolation can write to _forks/ without sandbox permission issues Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-23 18:15:44 +08:00
Parfii-bot	5b5e7c6d7b	feat(wave15): kei-fork — managed git-worktree + ledger lifecycle primitive 45 crates, 726 tests green (up from 713). Closes the ad-hoc `cp files from worktree` workflow that lost data when Claude Code auto-cleaned worktrees mid-session. After this crate ships, orchestrator never touches `git worktree` or manual `cp` again. ## Public API - `create(agent_id, base, kit_root)` → ForkHandle + ledger row - `collect(agent_id, msg, kit_root)` → commit + merge --no-ff + archive - `list(kit_root, status_filter)` → Active/Done/Stale/Merged enumeration - `gc(kit_root, hours)` → prune stale forks (git + branch + ledger fail) - `rescue(agent_id, kit_root, out)` → salvage files live or from archive ## Key design decisions - Worktrees indexed by agent_id (`.claude/forks/<agent_id>/`), NOT uuid — grepable, no more "which worktree has my files" confusion. - `.DONE` marker gates collect — agent signals completion explicitly. - Archive path `_archive/forks/YYYY-MM-DD/<agent_id>/` preserves history. - `KEI_FORK_SKIP_LEDGER=1` env for hermetic tests. - Constructor Pattern: 10 modules, largest file main.rs 137 LOC. 13 hermetic integration tests via tempfile + git-init kit_roots. Next: wire kei-fork into kei-spawn for the three-role pipeline (Writer → Auditor → Merger with branch-as-sandbox). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-23 17:43:20 +08:00

Author

SHA1

Message

Date

Parfii-bot

5f7a5b2639

fix(wave18): 8 HIGH audit findings closed + three-role pipeline actually built

47 crates, 801 tests green (up from 771 at v0.34.0). Wave 18 audit
found 8 HIGH findings across architect/critic/security/validator. All
closed. Three-role pipeline REBUILT after validator discovered Wave 16
commit was a half-commit (files claimed but never tracked).

## A. Three-role pipeline (REBUILD — was missing from v0.33.0 despite
      CHANGELOG claim)

Files validator flagged absent: _roles/auditor.toml + merger.toml,
4 _capabilities/{policy/git-ops-scope,output/verdict,output/merge-result,
verify/fork-audit}/text.md, kei-spawn/src/{pipeline,precedent}.rs,
pipeline_smoke.rs + pipeline_unit.rs tests. ALL NOW REAL (verified by
git log --all and `ls`).

- auditor role: claude-subagent-type=critic, handoff=[merger]
- merger role: git-ops scope, claude-subagent-type=infra-implementer,
  leaf (empty handoff)
- 5 capability text.md (+ capability.toml for each) defining contracts
- kei-spawn pipeline.rs (171 LOC): pipeline_from_role, derive_steps,
  emit_pipeline_json, scaffold_downstream_tasks
- kei-spawn precedent.rs (118 LOC): env-gated advisory shell-out
- --pipeline flag on spawn subcommand
- +11 tests (pipeline_smoke + pipeline_unit)

## B. kei-fork — 4 HIGH fixes (Critic F1+F7a, Security #3+#4)

- `git add -A` → explicit path list from ls-untracked + ls-modified,
  with exclusion filter for .DONE / .KEI_FORK_META.toml / _archive/ /
  _forks/. No more merge bleed. +1 regression test.
- create() rollback: on write_meta or ledger_fork failure, worktree
  + branch cleaned. +1 test via KEI_FORK_FORCE_LEDGER_FAIL=1.
- worktree_add arg injection: added `--` sentinel + is_safe_refname()
  validator (refuses dash-leading, NUL, ..). +3 tests.
- PATH hijack: KEI_FORK_GIT_BIN env override for all Command::new(git).
  +1 test.

## C. kei-spawn — 2 HIGH fixes (Security #1+#2)

- HTTP body unbounded DoS: MAX_BODY_BYTES=10MiB + content-length
  pre-check + streamed cap (io::Read::take) for chunked encoding.
  +2 feature-gated tests.
- PATH hijack: KEI_LEDGER_BIN env override already existed at
  ledger_sh.rs:15; documented precedence + added 4 regression tests
  locking the 3-tier lookup order.

## D. kei-ledger-sign — 1 HIGH fix (Security #2)

- save_keypair atomic POSIX open(2) O_CREAT|O_EXCL + mode 0o600 +
  rename(2) into place. No race window where key is world-readable.
  +2 tests.

## E. spawn_from_task rollback (Critic F7b)

- register_in_ledger helper: on ledger fork failure, rollback_task_dir
  before error propagation. +1 test spawn_rolls_back_task_dir_on_ledger_fail.

## Audit summary

- architect: GO conditional (taxonomy 19% — defer)
- critic: HIGH closed, MEDIUM debt logged
- security: 4 HIGH closed; MEDIUM (tar symlink, watcher symlink) tracked
- validator: CHANGELOG no longer lies — three-role pipeline is real
- patent-compliance: GO / LOW risk unchanged

All 8 HIGH blockers from Wave 18 consolidated audit → GREEN.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-23 20:54:59 +08:00

Parfii-bot

32f2e8a288

feat(wave15): kei-dna-index + kei-fork Option-D path convention fix

46 crates, 744 tests green (up from 726 at v0.31.0).

## kei-dna-index (new) — read-only adjacency analysis over kei-ledger

Answers "who else touched same files / solved same task / ran nearby in
time". Does NOT mutate ledger — parses DNA strings in memory. Respects
SSoT (DNA string is the single source; columns NOT duplicated).

Public API:
- adjacent(target_dna, kind) — 5 kinds: Scope / Body / Role / Temporal / All
- cluster_by(scope|body|role) — group DNAs, ≥2 members per cluster
- precedent(body_sha, status_filter) — find past successful runs of same task
- stats — totals, unique scopes/bodies, avg cluster size

CLI:
- kei-dna-index adjacent --dna D [--by kind] [--limit N] [--db PATH]
- kei-dna-index cluster --by scope|body|role
- kei-dna-index precedent --body HEX [--status merged|failed|all]
- kei-dna-index stats

18 tests pass (13 integration + 5 parsed unit). Zero sibling deps
(no kei-ledger, no kei-agent-runtime path imports — standalone tool).

Separation of concerns: kei-ledger stays PURE provenance primitive.
Analytical layer lives in kei-dna-index. Can swap implementations
(naive scan → cached → embeddings) without touching ledger schema.

## kei-fork v0.31.2 — Option D path convention

Moved fork worktree root from `.claude/forks/<id>/` to `_forks/<id>/`.
Reasons:
- `.claude/` is Anthropic-reserved; kit artefacts shouldn't pollute it
- Claude Code sandbox denies Write in `.claude/forks/` for agents
- `_forks/` matches existing kit convention (_primitives/, _roles/,
  _archive/, _blocks/, _capabilities/, _agents/)
- Independent namespace — no coupling to Claude Code internals

13 existing kei-fork tests still pass (they use tempfile kit_roots
so path convention is transparent).

## Usage enabled by these two

- kei-prune can now query "all DNAs in same scope-cluster" → retire dupes
- kei-brain-view can cluster-render instead of tree-render
- Three-role pipeline (writer/auditor/merger) can use precedent() to
  find successful past patterns for same body-hash
- Agents with worktree isolation can write to _forks/ without sandbox
  permission issues

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-23 18:15:44 +08:00

Parfii-bot

5b5e7c6d7b

feat(wave15): kei-fork — managed git-worktree + ledger lifecycle primitive

45 crates, 726 tests green (up from 713).

Closes the ad-hoc `cp files from worktree` workflow that lost data when
Claude Code auto-cleaned worktrees mid-session. After this crate ships,
orchestrator never touches `git worktree` or manual `cp` again.

## Public API
- `create(agent_id, base, kit_root)` → ForkHandle + ledger row
- `collect(agent_id, msg, kit_root)` → commit + merge --no-ff + archive
- `list(kit_root, status_filter)` → Active/Done/Stale/Merged enumeration
- `gc(kit_root, hours)` → prune stale forks (git + branch + ledger fail)
- `rescue(agent_id, kit_root, out)` → salvage files live or from archive

## Key design decisions
- Worktrees indexed by agent_id (`.claude/forks/<agent_id>/`), NOT uuid —
  grepable, no more "which worktree has my files" confusion.
- `.DONE` marker gates collect — agent signals completion explicitly.
- Archive path `_archive/forks/YYYY-MM-DD/<agent_id>/` preserves history.
- `KEI_FORK_SKIP_LEDGER=1` env for hermetic tests.
- Constructor Pattern: 10 modules, largest file main.rs 137 LOC.

13 hermetic integration tests via tempfile + git-init kit_roots.

Next: wire kei-fork into kei-spawn for the three-role pipeline
(Writer → Auditor → Merger with branch-as-sandbox).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-23 17:43:20 +08:00

3 commits