2 commits

Author	SHA1	Message	Date
Parfii-bot	187661714f	fix(kei-model-router): close 10 audit-blocker findings ... Codex CRITICAL + 4 HIGH + 5 MEDIUM/LOW from RULE 0.23 dual-review and RULE 0.25 multi-critic swarm — all closed. CRITICAL fix - Model::slug() ledger compatibility: posterior.rs + select_kernel.rs query `WHERE model = ?2 OR model = ?3`, binding canonical + legacy slug pair via new `Model::legacy_slug()`. Production ledger rows written under "haiku"/"sonnet"/"opus" remain visible to posterior aggregation. Regression test ledger_legacy_slug_counted. HIGH fixes - cmd_select(): no longer early-returns on profile match. Profile's default_model_ref now becomes DecisionInput.fallback; select() always runs, posterior/kernel evidence wins if present. RULE 0.20 cost optimisation restored for all 18 registered agents. - Registry pricing SSoT: DecisionInput now carries Option<Arc<Registry>>. estimated_cost() tries registry first; hardcoded match is documented fallback only. select_posterior.rs no longer duplicates models.toml constants. - registry.rs portability: include_str!() embeds the three TOMLs at compile time. load_embedded() new; disk path tried first via KEI_REGISTRIES_DIR, embedded as fallback. `cargo install`d binaries now find registries unconditionally. embedded_registry_matches_disk test ensures embedded ≡ disk source. - next_model() ambiguity: replaced Option<&Model> with EscalationResult enum (Next(&Model) / AtTop / NotFound). Callers can distinguish typo from ceiling. 5 new tests. MEDIUM fixes - posterior.rs u32 overflow: `(n_plus + n_minus) as u32` → `u32::try_from(n_plus.saturating_add(n_minus)).unwrap_or(u32::MAX)`. overflow_guard_on_huge_n test with i64::MAX. - pick() unknown-model: now returns None when default_model_ref's model is absent from registry. Inverted the deprecation guard. - HOME unset: disk_registries_dir() returns None on empty HOME and falls through to embedded registries. open_ledger() logs warning and returns None instead of opening at malformed path. - SQLite WAL + busy_timeout: applied to ledger connection in open_ledger() — concurrent CLI invocations no longer SQLITE_BUSY. LOW fixes - impl Model consolidation: next_tier() moved to pricing.rs. escalate.rs uses current.next_tier() instead of duplicating logic. - complexity.rs: removed duplicate "ml-implementer" in HEAVY_ROLES. - dna_class.rs: role("") now returns None instead of Some(""). Verification (orchestrator-side, RULE 0.13 §Verify-before-commit): - cargo check → clean - cargo test --release → 63 passed / 0 failed (was 58 → +5 new tests cover legacy-slug, EscalationResult, overflow, unknown-model, embedded) - Constructor Pattern → all files ≤ 200 LOC (max registry.rs 196) - Largest fn from_ledger 28 LOC / limit 30 DNA-INDEX.md regenerated by kei-registry hook (cosmetic). === STATUS-TRUTH MARKER === shipped: functional stubs: 0 cargo-check: PASS behaviour-verified: yes follow-up-required: - (none from this commit; next audit pass before merge to main)	2026-05-13 22:09:19 +08:00
Parfii-bot	4d79049eff	feat(kei-model-router): registry-driven, three-layer DNA ... Removes hardcoded Claude-only Model enum. Pricing constants now read from _blocks/registries/models.toml at startup; provider/model lookup goes through a typed Registry returned by registry.rs. New API surface: - Registry::load(dir) → (providers, models, profiles) - pick(profile_id, &Registry) → Result<(provider_id, model_id)> - cost_micro_cents(model_id, in, out, &Registry) → Option<u64> - next_model(model_id, &Registry) → Option<&Model> (ascending cost, same provider, skip deprecated) Files: - registry_types.rs new 107 LOC (Provider/Model/Profile structs) - registry.rs new 152 LOC (TOML load + lookups) - pricing.rs rew 127 LOC (registry-backed, no constants) - escalate.rs rew 181 LOC (registry-backed ladder + skip deprecated) - select.rs rew 131 LOC - select_kernel.rs new 74 LOC (Constructor-Pattern split) - select_posterior.rs new 178 LOC (Constructor-Pattern split) - posterior.rs rew 197 LOC - calibrate.rs rew 175 LOC - lib.rs rew 53 LOC - main.rs rew 163 LOC (CLI updated to new API) - Cargo.toml dep added toml 0.8 Verification (orchestrator-side, RULE 0.13 §Verify-before-commit): - cargo check → clean - cargo test --release → 58 passed / 0 failed / 0 ignored - LOC limit (Constructor) → max 197 / limit 200 - largest fn cmd_select → ~27 LOC / limit 30 DNA-INDEX.md regenerated by kei-registry hook (primitive count 144 → 150 reflects the 6 new/split modules). === STATUS-TRUTH MARKER === shipped: functional stubs: 0 cargo-check: PASS behaviour-verified: yes follow-up-required: - select.rs `estimated_cost` still embeds inline cost constants mirroring models.toml; if non-Anthropic providers need dynamic pricing in select-time estimation, thread Registry through. - External callers of old `cost_micro_cents(Model, ...)` signature will break — intentional, no external callers in this workspace.	2026-05-13 21:23:53 +08:00